-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added spending plans for testing on testnet. #3136
Conversation
Signed-off-by: ebadiere <[email protected]> feat: Moved create aliases script to the sctrips directory. Signed-off-by: ebadiere <[email protected]> feat: Moved create alias accounts script to root ./scripts directory. Signed-off-by: ebadiere <[email protected]>
Signed-off-by: ebadiere <[email protected]>
Signed-off-by: ebadiere <[email protected]>
Quality Gate passedIssues Measures |
🚨 Memory Leak Detected 🚨A potential memory leak has been detected in the test titled Details📊 Memory Leak Detection Report 📊 GC Type: MarkSweepCompact Heap Statistics (before vs after executing the test):
Heap Space Statistics (before vs after executing the test):
RecommendationsPlease investigate the memory allocations in this test, focusing on objects that are not being properly deallocated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
const privateKey = PrivateKey.generateECDSA(); | ||
const publicKey = privateKey.publicKey; | ||
|
||
console.log(`Generated ECDSA Private Key: ${privateKey.toStringRaw()}`); | ||
console.log(`Generated ECDSA Public Key: ${publicKey.toStringRaw()}`); | ||
|
||
const ethereumAddress = publicKey.toEthereumAddress(); | ||
|
||
console.log(`Ethereum Address: 0x${ethereumAddress.toString()}`); | ||
|
||
const aliasAccountId = AccountId.fromEvmAddress(0, 0, ethereumAddress); | ||
|
||
const transferTx = await new TransferTransaction() | ||
.addHbarTransfer(operatorAccountId, initialBalanceTinybar.negated()) | ||
.addHbarTransfer(aliasAccountId, initialBalanceTinybar) | ||
.execute(client); | ||
|
||
const receipt = await transferTx.getReceipt(client); | ||
console.log(`Transfer Transaction Status: ${receipt.status.toString()}`); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works fine, but I've seen the AccountCreateTransaction
API used before, like this:
TransactionResponse newAccount = new AccountCreateTransaction()
.setKey(newAccountPublicKey)
.setInitialBalance(Hbar.fromTinybars(1000))
.execute(client);
Just a suggestion—no need to change anything!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Covered by #3201 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3136 +/- ##
==========================================
+ Coverage 82.11% 82.69% +0.58%
==========================================
Files 65 62 -3
Lines 4355 4195 -160
Branches 859 821 -38
==========================================
- Hits 3576 3469 -107
+ Misses 526 483 -43
+ Partials 253 243 -10
Flags with carried forward coverage won't be shown. Click here to find out more. |
feat: Moved create aliases script to the sctrips directory.
Description:
This PR replaces PR #3116 with minimal package.json changes.
Related issue(s):
Fixes #3111
Checklist